[BUGFIX stable] EmberComponent's element is an Element
#20491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glimmer's notion of a component `element` is a `SimpleElement`, though, so we have one cast that is something of a "lie"; but this is important to preserve for the public API of `EmberComponent` since we document it as such.
NullVoxPopuli
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glimmer's notion of a component
elementis aSimpleElement, though, so we have one cast that is something of a "lie"; but this is important to preserve for the public API ofEmberComponentsince we document it as such.elementin classic components no longer is a "normal" HTMLElement in the stable types #20485 (if we merge it!).