[BUGFIX release] Expose @glimmer/syntax from template compiler privately for use in Embroider.
#19426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
expose-glimmer-syntax-from-template-compiler
branch
from
1fa1192
to
15ae641
Compare
…ately for use in Embroider. This enables Embroider to remove some gnarly hacks (or at least only resort to them when operating on older Ember).
rwjblue
force-pushed
the
expose-glimmer-syntax-from-template-compiler
branch
from
15ae641
to
b46eee7
Compare
|
Thanks! Haven't had a chance to try this yet. I think we have been broken under canary for a little while due to template-compiler distribution changes, this gives me a stable target to switch to. |
Yes, that is precisely why I did this 😉. Seemed better than just fixing the monkey patch... @ef4 - The test added here is basically exactly what we want to do. |
rwjblue
added a commit
to rwjblue/embroider
that referenced
this pull request
Feb 26, 2021
New API exposed in emberjs/ember.js#19426 enables us to avoid munging with the template compiler internals.
rwjblue
added a commit
to rwjblue/embroider
that referenced
this pull request
Feb 26, 2021
This API was introduced in emberjs/ember.js#19426 and allows us to avoid Ember's own AST transform plugins. The changes here are safe across all Ember version ranges (in both cases applyTransforms avoids running Ember's own transforms).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables Embroider to remove some gnarly hacks (or at least only resort to them when operating on older Ember).
Closes #18095