[BUGFIX beta] Update glimmer-vm to prevent errors for older inline precompilation #19370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
changed the title
|
Will need to be rebased on #19371 (will fail until that lands). |
This updates glimmer-vm to avoid emitting the `scope` property on precompiled template blocks when not using strict mode (when using strict mode `scope` will either be `null` or a function). This is specifically to work around a bug in older versions of babel-plugin-htmlbars-inline-precompile (versions from v2.0.0 through v4.0.1) where they would (incorrectly) attempt to build an `ObjectExpression` when a `null` value is found in the template precompilation result (D'oh!). Note: those versions of babel-plugin-htmlbars-inline-precompile should still be migrated away from (they are quite old, and will definitely not work for newer features like strict mode).
rwjblue
force-pushed
the
prevent-inline-compilation-errors-for-older-htmlbars-precompile
branch
from
1a1d33c
to
9bc0b49
Compare
|
Rebased to incorporate changes from #19371 |
rwjblue
deleted the
prevent-inline-compilation-errors-for-older-htmlbars-precompile
branch
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates glimmer-vm to avoid emitting the
scopeproperty on precompiled template blocks when not using strict mode (when using strict modescopewill either benullor a function).This is specifically to work around a bug in older versions of babel-plugin-htmlbars-inline-precompile (versions from v2.0.0 through v4.0.1) where they would (incorrectly) attempt to build an
ObjectExpressionwhen anullvalue is found in the template precompilation result (D'oh!).Note: those versions of babel-plugin-htmlbars-inline-precompile should still be migrated away from (they are quite old, and will definitely not work for newer features like strict mode).
Fixes #19331