Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE dynamic-helper-and-modifier] Add dynamic helper usage #19309

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Dec 15, 2020

Adds the ability to use dynamic helper based on either helper definitions directly, or currying helpers with the (helper) keyword. Also adds a canary flag for this feature.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems good!

We need address the gap in helper invocation (even without the (helper helper, you could be exposed to issues with the AST transform that rewrites {{foo.bar 'bat'}} to {{component foo.bar 'bat'}}).

@pzuraq pzuraq force-pushed the update/bump-vm-enable-dynamic-helpers-components branch 2 times, most recently from 7e14be6 to 1bf7fd5 Compare December 16, 2020 04:29
Enables dynamic helper usage based on either helper definitions
directly, or currying helpers with the (helper) keyword.
@pzuraq pzuraq force-pushed the update/bump-vm-enable-dynamic-helpers-components branch from 1bf7fd5 to f8339c3 Compare December 16, 2020 19:00
@pzuraq
Copy link
Contributor Author

pzuraq commented Dec 16, 2020

We were able to fix the issue with component transforms upstream and avoid it altogether, we can remove the transform entirely now 😄

@pzuraq pzuraq changed the title [FEATURE dynamic-helper-and-modifier] Enable dynamic helper usage [FEATURE dynamic-helper-and-modifier] Add dynamic helper usage Dec 16, 2020
@rwjblue rwjblue merged commit e464c73 into master Dec 16, 2020
@rwjblue rwjblue deleted the update/bump-vm-enable-dynamic-helpers-components branch December 16, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants