Update the Glimmer VM to 0.68.0 #19293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
resolution-refactors
branch
from
72232ea
to
4e6b40e
Compare
rwjblue
approved these changes
Dec 3, 2020
packages/@ember/-internals/glimmer/lib/component-managers/mount.ts
Outdated
Show resolved
Hide resolved
| this.isInteractive = isInteractive; | ||
|
|
||
| this.builtInModifiers = { | ||
| action: { manager: new ActionModifierManager(), state: null }, | ||
| on: { manager: new OnModifierManager(owner, isInteractive), state: null }, | ||
| action: actionModifier, |
There was a problem hiding this comment.
This will make it somewhat more hoop jumping over in #19227.
pzuraq
force-pushed
the
resolution-refactors
branch
3 times, most recently
from
763cd45
to
8a686a8
Compare
Updates the VM to the latest version, which includes a number of major changes: - Refactors the resolver to not cache values, as this is unnecessary - Refactors the resolver to return helper/modifier definitions directly - Refactors the resolver to return ResolvedComponentDefinitions - Updates various component definitions - Removes custom helper, modifier, and component managers - Updates built-in helpers to be based on objects with associated helpers/helper managers.
pzuraq
force-pushed
the
resolution-refactors
branch
from
8a686a8
to
49d5291
Compare
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the VM to the latest version (0.68.0), which includes a number of major
changes:
helpers/helper managers.
even with legacy 3.13 capabilities. The pass a look-alike instead, which is generally
similar, but does not include type injections. As such, if anyone was relying on type
injections there could be breakage. This is pretty unlikely, which is why we are
making this change, but in the event that it was something folks were using we
should fix this.
Notes for the VM release.