[BUGFIX release] Ensure user lifecycle hooks are untracked #19193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Oct 13, 2020
When we refactored the VM to use autotracking internally, some lifecycle hooks were tracked that previously weren't on classic components. This PR ensures those hooks are no longer tracked, maintaining their previous behavior.
pzuraq
force-pushed
the
bugfix/ensure-user-lifecycle-hooks-are-untracked
branch
from
0a1cbee
to
35ca781
Compare
rwjblue
approved these changes
Oct 13, 2020
|
FWIW, we chatted RE: my concern above and decided that we did not want to introduce deprecations at the moment for this. Specifically: resolving these deprecations would largely just be a waste of work (since the real path forward is migration to |
xg-wang
reviewed
Oct 22, 2020
| this.foo = 123; | ||
| } | ||
| }, | ||
| template: '{{this.baz}}', |
There was a problem hiding this comment.
Dumb question when reading the diff, should it be {{this.foo}}?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we refactored the VM to use autotracking internally, some lifecycle hooks were tracked that previously weren't on classic components. This PR ensures those hooks are no longer tracked, maintaining their previous behavior.
Fixes #19192