New options for deprecate() function #19133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehulkar
commented
Sep 24, 2020
rwjblue
reviewed
Sep 24, 2020
rwjblue
requested changes
Sep 24, 2020
There was a problem hiding this comment.
Thanks for working on this @mehulkar!
We should:
- Add some deprecation flagging around the new deprecations (see
8b7d402(#18436) as an example) - Update all existing callsites of
deprecateto pass the new options (Ember itself should not trigger this deprecation) - Address the inline comments
@rwjblue bit confused about what to do here. Is the "deprecated feature" here the ability to call |
rwjblue
reviewed
Oct 5, 2020
mehulkar
commented
Oct 5, 2020
| @@ -64,6 +64,10 @@ if (DEBUG) { | |||
| deprecate(message, false, { | |||
| id: 'autotracking.mutation-after-consumption', | |||
| until: '4.0.0', | |||
| for: 'ember-source', | |||
| since: { | |||
| enabled: '3.21.0', | |||
rwjblue
reviewed
Oct 5, 2020
rwjblue
reviewed
Oct 5, 2020
rwjblue
reviewed
Oct 5, 2020
rwjblue
reviewed
Oct 6, 2020
mehulkar
commented
Oct 6, 2020
| export interface DeprecationOptions { | ||
| id: string; | ||
| until: string; | ||
| url?: string; | ||
| for: string; | ||
| since: Partial<Record<DeprecationStages, string>>; |
There was a problem hiding this comment.
Thanks for the assist @dfreeman!
|
@mehulkar - Mind squashing this down? Once that is done, we can land... |
This implements the first stage of the Deprecation Staging RFC emberjs/rfcs#649 This commit also: - deprecates the usage of deprecate() function without passing these options - Updates all the usages of deprecate() in the repo to pass these options.
|
Squashed and pushed! |
|
Thanks again! |
chancancode
added a commit
to chancancode/ember-moment
that referenced
this pull request
Oct 27, 2020
Since emberjs/ember.js#19133, ember-source requires passing a `since` option to the `deprecate` function. Since this deprecation is targeted for removal in 8.0 anyway, seems like we can just remove it instead of fixing the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
forandsinceoptions for thedeprecate()function as detailed in github.com/emberjs/rfcs/pull/649 Not sure if it's the right place to start, but seemed like the lowest hanging fruit.cc @rwjblue @pzuraq