Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Upgrades Glimmer VM to 0.47.9 #18743

Merged
merged 6 commits into from
Feb 21, 2020
Merged

[BUGFIX beta] Upgrades Glimmer VM to 0.47.9 #18743

merged 6 commits into from
Feb 21, 2020

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Feb 14, 2020 •
edited by rwjblue
Loading

Fixes #18732
Fixes #18693

@krisselden
Copy link
Contributor

krisselden commented Feb 14, 2020 •
edited
Loading

Are there tests for the fixed issues?

rwjblue
rwjblue reviewed Feb 15, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update seems good, but I’d love to get some tests for those specific regressions.

@rwjblue rwjblue merged commit b628b21 into master Feb 21, 2020
@rwjblue rwjblue deleted the bugfix/upgrade-glimmer-vm-0.47.9 branch February 21, 2020 23:39
@rwjblue rwjblue mentioned this pull request Feb 23, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@pzuraq @krisselden @rwjblue @GCheung55