[BUGFIX beta] Eagerly consume aliases #18329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reverts alias's behavior to eagerly consume their alternate keys when being observed or depended on by other CPs, the same behavior they had prior to enabling tracked properties. This reintroduces a bug where this would cause aliased values to be eagerly computed if they were observed via their alias, but as this was a known issue with a workaround, it's a better alternative to introducing a much larger change in behavior.
krisselden
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts alias's behavior to eagerly consume their alternate keys
when being observed or depended on by other CPs, the same behavior they
had prior to enabling tracked properties. This reintroduces a bug where
this would cause aliased values to be eagerly computed if they were
observed via their alias, but as this was a known issue with a
workaround, it's a better alternative to introducing a much larger
change in behavior.
Fixes #18318