Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-router-generator from v1.2.3 to v2.0.0 #18278

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

xg-wang
Copy link
Contributor

@xg-wang xg-wang commented Aug 17, 2019

To support parsing app/router.js with native class.

For some reason @dependabot-bot didn't run.

To support parsing app/router.js with native class
@xg-wang
Copy link
Contributor Author

xg-wang commented Aug 17, 2019

Failing test seems irrelevant, it's passing on another travis build https://travis-ci.com/xg-wang/ember.js/jobs/226016602

@pzuraq pzuraq merged commit 1f9d38e into emberjs:master Aug 19, 2019
@pzuraq
Copy link
Contributor

pzuraq commented Aug 19, 2019

Thanks for the PR!

@xg-wang xg-wang deleted the feat/router-class branch August 19, 2019 18:28
@rwjblue
Copy link
Member

rwjblue commented Aug 20, 2019

Should be a bugfix beta, allowing native classes in 3.13 as well. Backporting now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants