Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove intimate apis in the router #17843

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Remove intimate apis in the router #17843

merged 1 commit into from
Apr 3, 2019

Conversation

chadhietala
Copy link
Contributor

Unsure if this should be cherry picked to the release or not.

@chadhietala chadhietala requested a review from rwjblue April 2, 2019 19:19
@rwjblue
Copy link
Member

rwjblue commented Apr 2, 2019

The CI failures seem related:

Test failed: Deprecated HandlerInfos: handlerInfos are deprecated and associated private apis", source: (49)

pzuraq
pzuraq approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@pzuraq pzuraq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminded me I need to do the same

@pzuraq pzuraq mentioned this pull request Apr 3, 2019
Merged
@chadhietala chadhietala merged commit f9bb0cd into master Apr 3, 2019
@chadhietala chadhietala deleted the remove-intimate-apis branch April 3, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pzuraq pzuraq pzuraq approved these changes

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chadhietala @rwjblue @pzuraq