Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix octane component blueprint and octane blueprint tests #17740

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

ppcano
Copy link
Contributor

@ppcano ppcano commented Mar 14, 2019

Closes #17737. The removal of the MU layout from the Octane edition requires to do some changes on the blueprints.

  • Change the octane blueprint tests to disable the MU layout and fix the blueprint tests.

  • Fix octane in-addon component blueprint (based on the sparkless addon blueprint implementation).

@rwjblue rwjblue merged commit c4e7038 into emberjs:master Mar 14, 2019
@rwjblue
Copy link
Member

rwjblue commented Mar 14, 2019

Thank you @ppcano!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Octane blueprint tests
2 participants