[BUGFIX canary] Ensure @tracked setter triggers a revalidation. #17682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
failing-test-for-tracked-set-outside-runloop
branch
from
d70e3eb
to
47d201a
Compare
rwjblue
changed the title
rwjblue
force-pushed
the
failing-test-for-tracked-set-outside-runloop
branch
from
47d201a
to
f49c873
Compare
rwjblue
force-pushed
the
failing-test-for-tracked-set-outside-runloop
branch
from
f49c873
to
9ba35a1
Compare
|
Looks good to me. I'm a little surprised that the lower-level abstractions (maybe |
tomdale
approved these changes
Feb 28, 2019
Prior to this change, setting a tracked property when there was on ambient runloop would never schedule a revalidation and would therefore never rerender. This change ensures that _any_ set of a `@tracked` property will enqueue a revalidation regardless if there is a current runloop or not.
rwjblue
force-pushed
the
failing-test-for-tracked-set-outside-runloop
branch
from
9ba35a1
to
028799f
Compare
pzuraq
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, setting a tracked property when there was on ambient runloop would never schedule a revalidation and would therefore never rerender.
This change ensures that any set of a
@Trackedproperty will enqueue a revalidation regardless if there is a current runloop or not.