Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX lts] support numbers in component names for Angle Brackets #17552

Merged
merged 1 commit into from
Feb 2, 2019
Merged

[BUGFIX lts] support numbers in component names for Angle Brackets #17552

merged 1 commit into from
Feb 2, 2019

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Feb 2, 2019

Previously, a component named c3-plot would not work when invoked as <C3Plot />.
Now it will resolve correctly.

Closes #17549

Behavior:

'F3Bar' => 'f3-bar'
'Foo3Bar' => 'foo3-bar'
'Foo3barBaz' => 'foo3bar-baz'
'FooB3ar' => 'foo-b3ar'

Notably it does not support Foo2bar => foo-2bar, but it did not support it before this change either.

It's a bit edge-casey but I think given the prevalent use of C3 and D3 in JS, it makes sense to lean towards this patch's behavior.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, can you change the commit prefix to [BUGFIX lts]?

@rwjblue rwjblue changed the title [BUGFIX beta] support numbers in component names for Angle Brackets [BUGFIX lts] support numbers in component names for Angle Brackets Feb 2, 2019
Previously, c3-plot would not work when invoked as <C3Plot />.
Now it will resolve correctly.
Closes #17549
@jenweber
Copy link
Contributor Author

jenweber commented Feb 2, 2019

Done! Thanks for the tips on which files to look at to fix this.

@rwjblue rwjblue merged commit d940958 into emberjs:master Feb 2, 2019
@rwjblue
Copy link
Member

rwjblue commented Feb 2, 2019

Hehe, well it was my fault to begin with so....

@rwjblue
Copy link
Member

rwjblue commented Feb 2, 2019

Thank you for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some components with numbers in the name don't work with Angle Brackets
2 participants