[BUGFIX release] Ensure legacy build of template compiler can be loaded. #17403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change the following error was triggered:
```
node -e 'require("ember-source/dist/legacy/ember-template-compiler")'
/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:21
throw new Error('Could not find module ' + name + ' required by: ' + referrerName);
^
Error: Could not find module ember-babel required by: @glimmer/compiler
at missingModule (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:21:13)
at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:45:7)
at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
at requireModule (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:99:14)
at /Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:14842:92
at Object.<anonymous>
(/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:14845:2)
```
This happened because the `ember-template-compiler.js` bundle did not
include the babel helpers needed.
pzuraq
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change the following error was triggered:
This happened because the
ember-template-compiler.jsbundle did not include the babel helpers needed.Fixes #17402