[BUGFIX beta] Assert when local variables shadow modifier invocations #17137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanding #17132 to cover modifiers. ```hbs {{#let this.foo as |foo|}} <div {{foo}} /> ~~~ shadowed modifier invocation! {{/let}} ``` Previously, this would have tried to resolve and invoke the modifier `foo`, ignoring the presence of the `foo` local variable. This is inconsistent with our general lexical lookup rules. This is now an error (assertion). This paves the way for allowing "contextual modifiers" in the future, where the local variable `foo` contains an invocable modifier value.
chancancode
force-pushed
the
assert-local-variable-shadowing-modifier-invocation
branch
from
b85c38c
to
74b8f60
Compare
rwjblue
approved these changes
Oct 20, 2018
rwjblue
deleted the
assert-local-variable-shadowing-modifier-invocation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding #17132 to cover modifiers.
Previously, this would have tried to resolve and invoke the modifier
foo, ignoring the presence of thefoolocal variable. This is inconsistent with our general lexical lookup rules. This is now an error (assertion).This paves the way for allowing "contextual modifiers" in the future, where the local variable
foocontains an invocable modifier value.