Deprecate Ember.merge #16956
Deprecate Ember.merge #16956
Conversation
| let eventOpts = merge({}, DEFAULT_EVENT_OPTIONS); | ||
| merge(eventOpts, options); | ||
| let eventOpts = assign({}, DEFAULT_EVENT_OPTIONS); | ||
| assign(eventOpts, options); |
There was a problem hiding this comment.
Can you replace this with a single assign?
| let eventOpts = merge({}, DEFAULT_EVENT_OPTIONS); | ||
| merge(eventOpts, options); | ||
| let eventOpts = assign({}, DEFAULT_EVENT_OPTIONS); | ||
| assign(eventOpts, options); |
There was a problem hiding this comment.
Same here? We should only need one assign...
| deprecate('Use of `merge` has been deprecated. Please use `assign` instead.', false, { | ||
| id: 'ember-polyfills.deprecate-merge', | ||
| until: '4.0.0', | ||
| url: 'https://emberjs.com/deprecations/v3.x/#toc_ember-polyfills-deprecate-merge', |
There was a problem hiding this comment.
Is this created yet? Can you link me to the deprecation app PR?
There was a problem hiding this comment.
This is not created yet. I need to look into what I need to do for that.
There was a problem hiding this comment.
Just created it ember-learn/deprecation-app#179
|
We also need to guard this with deprecation flags for svelting, something like #16745. |
|
@rwjblue I added a link to the deprecations app PR and attempted the svelting stuff. Not sure I did it exactly right, so feel free to let me know what I should tweak. One thing I wasn't sure on is what version we should mark this deprecation as introduced in? I randomly chose 3.5 for both the svelting here and the deprecations app PR, but I think it will have to be a later version probably, since I think 3.5 beta has already been cut? |
|
Correct, master currently represents 3.6. We could backport the deprecation into 3.5 betas but I don’t see why we would necessarily want to do that so let’s just say 3.6... |
|
@rwjblue just updated to point to 3.6. Let me know if there are any other tweaks I should make 😄 |
|
I merged the deprecation PR, it should redeploy soon, would you mind confirming the url here works properly? Once we’ve done that we can merge... |
|
https://emberjs.com/deprecations/v3.x/#toc_ember-polyfills-deprecate-merge is up and working :) |
|
@rwjblue looks like it's deployed and working. Anything else we need to tweak here? |
No description provided.