Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RFC 232 mocha controller tests #16894

Merged
merged 1 commit into from
Sep 4, 2018

Conversation

Dhaulagiri
Copy link
Contributor

Addresses #16863.

This is based off of the work in #16865 so that commit should disappear once that PR gets merged.

@rwjblue
Copy link
Member

rwjblue commented Sep 4, 2018

Sorry for the delays here, I was on vacation and am only finally getting caught back up.

There are still two commits here, would you mind rebasing to drop out the duplicate one?

@Dhaulagiri
Copy link
Contributor Author

@rwjblue no problem, rebased out the first commit

@rwjblue rwjblue merged commit 2c56af4 into emberjs:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants