Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX Beta] Decrement counter of pending requests in the next tick #16550

Merged
merged 1 commit into from
Apr 20, 2018
Merged

[BUGFIX Beta] Decrement counter of pending requests in the next tick #16550

merged 1 commit into from
Apr 20, 2018

Conversation

cibernox
Copy link
Contributor

@cibernox cibernox commented Apr 19, 2018 •
edited
Loading

@cibernox cibernox changed the title Decrement requests in the next tick [BUGFIX] Decrement counter of pending requests in the next tick Apr 19, 2018
@cibernox cibernox changed the title [BUGFIX] Decrement counter of pending requests in the next tick [BUGFIX Beta] Decrement counter of pending requests in the next tick Apr 19, 2018
@rwjblue
Copy link
Member

rwjblue commented Apr 19, 2018

pendingRequests is maintained for ajaxSend and ajaxComplete events is failing because it assumes things are sync, you will need to update those tests to deal with the new async...

@cibernox cibernox force-pushed the decrement-requests-in-the-next-tick branch from 3235478 to f33dead Compare April 20, 2018 11:01
@cibernox
Copy link
Contributor Author

@rwjblue Fixed!

@rwjblue rwjblue merged commit b2a6235 into emberjs:master Apr 20, 2018
@cibernox cibernox deleted the decrement-requests-in-the-next-tick branch April 20, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cibernox @rwjblue