[BUGFIX lts] Enable _some_ recovery of errors thrown during render. #16174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `env.commit()` is not called after it has started, and another `env.begin()` starts Glimmer throws an error: ``` Error: a glimmer transaction was begun, but one already exists. You may have a nested transaction ``` This commit works around the issue by ensuring that if a transaction had been started, it is cleaned up even if an error was thrown during render.
|
I've confirmed that this restores the previous behaviour in earlier versions of Ember (for the cases in our app where we're causing exceptions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
env.commit()is not called after it has started, and anotherenv.begin()starts Glimmer throws an error:This commit works around the issue by ensuring that if a transaction had been started, it is cleaned up even if an error was thrown during render.
Fixes glimmerjs/glimmer-vm#484