Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove sync runloop queue. #16097

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jan 9, 2018

sync queue was only used/present for bindings to synchronize, and Ember.Binding (along with related code) is now completely gone.

`sync` queue was only used/present for bindings to synchronize, and
Ember.Binding (along with related code) is now completely gone.
@@ -16,11 +12,7 @@ function onEnd(current, next) {
run.currentRunLoop = next;
}

const backburner = new Backburner(['sync', 'actions', 'destroy'], {
sync: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this functionality in backburner was only for the sync queue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, we can remove it from BB and then cut a major

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, we will have to wait for a short while (because the legacy addon still needs to enable this functionality through Ember 3.4), but totally agree that it will be awesome to get rid of 😆

Copy link
Member

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 🔥 🔥

@@ -16,11 +12,7 @@ function onEnd(current, next) {
run.currentRunLoop = next;
}

const backburner = new Backburner(['sync', 'actions', 'destroy'], {
sync: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, we can remove it from BB and then cut a major

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants