Fix issue with unchaining ChainNodes (again) #15982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1396bec. From @krisselden > This is a serious bug and this doesn't actually fix the issue, > some refactoring to ember-metal has caused overriding watch to > issue unbalanced watch/unwatch calls. It needs to be bisected.
When mutating the chains (`remove()` here) we must call `writableChains()` to "fork" it from the parent.
chancancode
force-pushed
the
fix-chains
branch
from
ac10de2
to
8107e85
Compare
rwjblue
approved these changes
Dec 14, 2017
|
Why did the revert commit pass if you kept the test? |
|
#15983 on its own is failing as expected. I think I just confused travis here. |
bekzod
reviewed
Dec 15, 2017
| if (paths[path] > 0) { | ||
| paths[path]--; | ||
| } else { | ||
| return; |
There was a problem hiding this comment.
why not to add assert here to know that there was unbalanced unchain or is it too much ? @krisselden
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @bekzod