[CLEANUP] Remove _actions functionality #15914
Conversation
Along with related deprecations, asserts, and tests.
|
Tests have been ported to the legacy addon |
There was a problem hiding this comment.
Looking good!
One inline tweak (we can remove the whole willMergeMixin function in the action handler mixin, and can you also add a comment above
ember.js/packages/ember-metal/lib/mixin.js
Line 241 in d074b82
to make it clear that this can be removed after 3.4?
| delete props._actions; | ||
| } | ||
| } | ||
| willMergeMixin() {} |
There was a problem hiding this comment.
I think we can remove the implementation completely?
There was a problem hiding this comment.
Will this have issues with https://github.com/emberjs/data/blob/master/addon/-private/system/model/model.js#L1889
There was a problem hiding this comment.
No, removing this empty function shouldn’t affect that (we aren’t removing the functionality yet)...
|
@rwjblue should be good now |
|
Awesome, thank you!! |
Along with related deprecations, asserts, and tests.
Related: ember-2-legacy PR
Apart of: #15876