[BUGFIX] Fix computed sort regression when array prop initially null #15733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was my fault 🤕, was about to submit PR for this, good job @ilucin 👍 |
|
fixes #15732 |
|
Thank you! |
|
@rwjblue No probs. Shouldn't we release 2.16.1 with this fix included? |
|
We're already up to 2.16.2 (I think?), so I guess it would be 2.16.3? I'm waiting for this PR fix before upgrading, since the broken sort does break some functionality in my webapp :/ |
|
According to this; It looks like the fix is in 2.17-beta.2. Seems like it's going to be a few weeks before the fix is in stable channel, if it's targeted at 2.17... |
|
I've opened another PR #15746 (over release branch) for 2.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a regression introduced (commit) in a sort computed macro.
If an array property (that is being sorted) is initially null or other non-array value - when computed property is first evaluated observers wouldn't be set and computed property would never work again. Provided test pretty much says it all.