[BUGFIX lts] Mark error as handled before transition for error routes and substates #15689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work here! Can you prefix the commit with |
|
Sure will do. |
kratiahuja
force-pushed
the
fastboot-error-template
branch
from
b8668f8
to
128d4f3
Compare
kratiahuja
changed the title
kratiahuja
force-pushed
the
fastboot-error-template
branch
from
128d4f3
to
6e32f4e
Compare
|
Fixed more routing test that were wrapping around the error originally being thrown. Hopefully travis god is 🍏 now. |
|
Sauce test failures seem unrelated. This should be good to review. |
|
Ya, that sauce labs job has been giving us loads of grief lately. I definitely do not think this is related to your changes here. |
rwjblue
approved these changes
Oct 2, 2017
|
Thank you @kratiahuja! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently were not marking the error as "handled" before transitioning to the error route (even though we were handling the error by transitioning to the error route/substate). Due to this, the error was being bubbled up and thrown. In the browser this is fine, but in fastboot this causes the
visitpromise to be rejected and the error template to not be serialized.Super thank you and shout out to @rwjblue for helping figure out the fix!
cc: @rwjblue