Update router_js to 2.0.0. #15672
Merged
Update router_js to 2.0.0. #15672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
commented
Sep 19, 2017
| rollup: { | ||
| external: ['route-recognizer', 'rsvp'], | ||
| entry: 'router.js', | ||
| plugins: [{ | ||
| transform(code, id) { |
There was a problem hiding this comment.
These overrides are not needed any longer, the upstream repo has corrected its invalid internals...
The diff of the changes is pretty noisey (due to lots of general cleanup work that was done), but for the most part the changes are: * Drop support for non ES5 browsers (use `Array.isArray`, `Object.create`, etc directly) * Refactor the dist output to emit `module` entry point. * Update to use classes throughout the repo. * Ensure `Route.prototype.serialize` is called bound to the route instance.
rwjblue
force-pushed
the
update-router-js
branch
from
f7c3b44
to
e9399bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff of the changes is pretty noisey (due to lots of general cleanup work that was done), but for the most part the changes are:
Array.isArray,Object.create, etc directly)moduleentry point.Route.prototype.serializeis called bound to the routeinstance.