[FEATURE ember-routing-router-service] isActive and Cleanup #15414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef4
approved these changes
Jun 26, 2017
…ehaviors. * Ensure that `routerService.transitionTo` and `routerService.replaceWith` does not elide query params (even the are the default values). * Update implementation of `routerService.isActive` to handle query params. * Ensure that the `router:main` injection property into the routerService is at `_router`. * Remove `routerService.currentState` * Add tests around various query param edge cases with `transitionTo` / `replaceWith`
rwjblue
force-pushed
the
router-service-is-active
branch
from
91b5abe
to
3b9489c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routerService.transitionToandrouterService.replaceWithdoes not elide query params (even the are the default values).
routerService.isActiveto handle query params.router:maininjection property into the routerService isat
_router.routerService.currentStatetransitionTo/replaceWithMost of the work here is @scalvert's (thank you!!).
I paired with @ef4 at the F2F today to confirm the semantics match the router service RFC, and fix-up some edge cases around
isActive/transitionTo/replaceWith.