[DEPRECATION] #14754 deprecate canDispatchToEventManager
#15078
Conversation
habdelra
force-pushed
the
14754-deprecate-canDispatchToEventManager
branch
3 times, most recently
from
f470f89
to
4007121
Compare
|
|
||
| expectDeprecation(() => { | ||
| this.render(`{{x-foo}}`); | ||
| }, '[DEPERECATED] `canDispatchToEventManager` has been deprecated.'); |
There was a problem hiding this comment.
Should be [DEPRECATED] instead of [DEPERECATED].
| ComponentClass: Component.extend({ | ||
| eventManager: { | ||
| myEvent() { | ||
| assert.ok(true, 'custom event was triggered'); |
There was a problem hiding this comment.
It's not clear from how this test is written that this line of code is actually executing. Can you set a boolean and check it at the end, or use assert.expect?
There was a problem hiding this comment.
whoops--thats copy-pasta, that assert is completely unrelated to the changes in this PR
habdelra
force-pushed
the
14754-deprecate-canDispatchToEventManager
branch
from
4007121
to
f36fcbe
Compare
|
@rwjblue could I get your |
| @@ -138,6 +139,34 @@ moduleFor('EventDispatcher#setup', class extends RenderingTest { | |||
| this.$('div').trigger('myevent'); | |||
| } | |||
|
|
|||
| ['@test canDispatchToEventManager is deprecated'](assert) { | |||
| this.dispatcher.canDispatchToEventManager = null; | |||
There was a problem hiding this comment.
In theory, we should not need to force this to be null in this test, the default of undefined should be enough
| @@ -538,7 +538,16 @@ export default Mixin.create({ | |||
| let owner = getOwner(this); | |||
| let dispatcher = owner && owner.lookup('event_dispatcher:main'); | |||
|
|
|||
| if (dispatcher && dispatcher.canDispatchToEventManager === null) { | |||
| deprecate( | |||
| `[DEPRECATED] \`canDispatchToEventManager\` has been deprecated.`, | |||
There was a problem hiding this comment.
Let's have this message mention eventManager instead of canDispatchToEventManager, and also add the ${this} to the interpolation (so it's clear to someone seeing the deprecation which component caused it.
| !('canDispatchToEventManager' in dispatcher), | ||
| { | ||
| id: 'ember-views.event-dispatcher.canDispatchToEventManager', | ||
| until: '3.0.0' |
|
|
||
| init() { | ||
| this._super(); | ||
| assert('EventDispatcher should never be instantiated in fastboot mode. Please report this as an Ember bug.', environment.hasDOM); | ||
|
|
||
| deprecate( | ||
| `[DEPRECATED] \`canDispatchToEventManager\` has been deprecated.`, |
There was a problem hiding this comment.
Let's mention which file this is in.
There was a problem hiding this comment.
Also, you should not need to prefix the message with [DEPRECATED]
habdelra
force-pushed
the
14754-deprecate-canDispatchToEventManager
branch
from
523d8da
to
6810123
Compare
|
@rwjblue good morning sunshine, I need more |
|
Thank you @habdelra! |
This is to address the deprecation in #14754. I'm not sure if the deprecation message provides enough detail.