Phase 2 of public Router service - adding replaceWith #14861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, why is it still WIP (what things are you still looking to add)? |
|
As per our previous discussions, I wasn't sure if we wanted to try to add more to this or whether this was good to go as is. I'd prefer to keep these additions as small as possible so we can iterate faster. Thoughts? |
|
Yep, agreed. Lets keep the PR's small and focused. Per our chat in slack I think you have a few changes to make (WRT to transitions in the |
scalvert
changed the title
rwjblue
reviewed
Jan 21, 2017
| @public | ||
| */ | ||
| replaceWith() { | ||
| this.router.replaceWith(...arguments); |
There was a problem hiding this comment.
We should return here I believe...
Router Service RFC - adding replaceWith
scalvert
force-pushed
the
router-service
branch
from
11a0cbc
to
ae016ea
Compare
|
Awesome job, keep it up? 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the second phase of the public router service described in this RFC.
It extends the API with:
replaceWithStatus: Work in progress
Reviewers: @locks @rwjblue @ef4
Changes:
replaceWithmethod in public router serviceHow to test drive this PR: