run(rsvp, "reject") should not throw trying to dispatchError #14184
Conversation
| @@ -6,7 +6,7 @@ let getStack = function(error) { | |||
| var stack = error.stack; | |||
| var message = error.message; | |||
|
|
|||
| if (stack.indexOf(message) === -1) { | |||
| if (stack && stack.indexOf(message) === -1) { | |||
There was a problem hiding this comment.
synonymous with the previous behavior where it will Log/dispatch undefined if the error did not have a stack
|
Seems odd that the test is in runtime, but implementation is in metal. I guess the way your are excercising the bug is via RSVP (which is only in runtime). Is it possible to also add a test in metal? Also, can you determine what published major/minor this issue was introduced in? We should likely target that version for this BUGFIX. |
I put it where I thought it related with the other tests, I can move to metal though since you're likely right.
I don't believe it's in a stable release yet but I will verify. |
2.8.0-beta.1 is where it was first introduced. |
|
Nah, this test is good here. Can you prefix the commit with |
|
@rwjblue done |
|
@rwjblue ready and the one selenium job failing is failing against everyones PR so I'm assuming it's unrelated. |
Fixes #14182