[BUGFIX beta] Bring back Ember.Test.waiters. #13716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
add-back-test-waiters
branch
from
1df4cf2
to
0876dff
Compare
Brings back `Ember.Test.waiters` and adds a feature flag for exposing `Ember.Test.checkWaiters`.
rwjblue
force-pushed
the
add-back-test-waiters
branch
from
0876dff
to
c381acb
Compare
|
I updated this to feature flag the new public API, so that we can target fixing |
|
👍 this seems great @rwjblue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings back
Ember.Test.waiterswith a deprecation (in favor ofEmber.Test.checkWaiters).Closes #13603.
/cc @krisselden @mixonic