[Glimmer 2] Port partial tests
#13306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chancancode @wycats r+? |
| } | ||
| }); | ||
|
|
||
| QUnit.test('should render other templates registered with the container', function() { |
There was a problem hiding this comment.
✔️ should render other templates registered with the container
|
@chadhietala looks great to me other than two missing assertions! As a follow-up to this (you can send it as a separate PR if you prefer), can you add some tests to confirm whether we support accessing the "local variables" in the current scope inside a partial? e.g. |
This supersedes emberjs#13199
|
@chancancode Can you kick the sauce labs? Seems to have failed for unrelated reasons? |
|
🏃 kicked |
|
Thank you @chadhietala and @jheth!! |
This was referenced Apr 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #13199