[BUGFIX beta] Only add deprecated container after create when present. #12699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the object returned from calling `.create` on a non-extendable factory does not contain a `container` property, do not set it. Previously, in Ember 2.2.0 it was possible to use non-extendable factories that were frozen after creation. After the changes to add a mock container to `.create` and swap that with the deprecated property after `.create` was finished, we trigger errors for anything that is frozen or sealed.
|
Sweetness! |
|
LGTM 👍 |
rwjblue
added a commit
that referenced
this pull request
Dec 9, 2015
[BUGFIX beta] Only add deprecated container after create when present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the object returned from calling
.createon a non-extendable factory does not contain acontainerproperty, do not set it.Previously, in Ember 2.2.0 it was possible to use non-extendable factories that were frozen after creation. After the changes to add a mock container to
.createand swap that with the deprecated property after.createwas finished, we trigger errors for anything that is frozen or sealed.Addresses FirebaseExtended/emberfire#340