[BUGFIX beta] Make {{get something 'path.goes.here'}} work.
#12323
+121
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `get` keyword should be roughly the same as `Ember.get`, but previously we were asserting when the path included a `.`. This was most likely because in the non-dynamic key case we were always using a `KeyStream` instead of calling `source.get(newPath)` (a `KeyStream` will assert when its path includes a `.` but `BasicStream#get` will automatically create the correct stream for that path). This removes the asserts, hard coded `KeyStream` usage, and adds a number of tests for nested keys.
This was referenced Sep 10, 2015
|
lgtm |
rwjblue
added a commit
that referenced
this pull request
Sep 10, 2015
…t-helper
[BUGFIX beta] Make `{{get something 'path.goes.here'}}` work.
|
👍🦄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getkeyword should be roughly the same asEmber.get, but previously we were asserting when the path included a.. This was most likely because in the non-dynamic key case we were always using aKeyStreaminstead of callingsource.get(newPath)(aKeyStreamwill assert when its path includes a.butBasicStream#getwill automatically create the correct stream for that path).This removes the asserts, hard coded
KeyStreamusage, and adds a number of tests for nested keys.Fixes #12263.