[BUGFIX beta] Provide a helpful error for undefined closure actions. #12241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
better-error-for-unknown-closure-actions
branch
2 times, most recently
from
49a3ec7
to
53099c6
Compare
|
I was bitten by this earlier, this change makes the problem much clearer by moving it to the declaration phase vs invocation. |
In the following scenario:
```handlebars
{{#foo-bar blah=(action somethingThatIsUndefined)}}
Click Me!
{{/foo-bar}}
```
Previously, an error was only thrown when attempting to invoke
`this.attrs.blah()`. After this change a helpful error like the following
will be thrown:
```
An action could not be made for `somethingThatIsUndefined` in
< component object id>. Please confirm that you are using either
a quoted action name (i.e. `(action 'somethingThatIsUndefined')`)
or a function available in < component object id>.
```
rwjblue
force-pushed
the
better-error-for-unknown-closure-actions
branch
from
53099c6
to
eb01971
Compare
rwjblue
added a commit
that referenced
this pull request
Aug 30, 2015
…re-actions [BUGFIX beta] Provide a helpful error for undefined closure actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the following scenario:
Previously, an error was only thrown when attempting to invoke
this.attrs.blah(). After this change a helpful error like the following will be thrown:Fixes #12240.