[BUGFIX release] Fix Ember.computed.sum
#12170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return get(this, dependentKey).reduce((previousValue, currentValue, index, array) => { | ||
| const arr = get(this, dependentKey); | ||
|
|
||
| if (!isArray(arr)) { return initialValue; } |
There was a problem hiding this comment.
I believe this check should actually be
(arr === null || arr === undefined)
If arr is an object and doesn't have reduce we should throw, but not if it is just not an array or an array like.
There was a problem hiding this comment.
+1 That makes sense. Should it throw if arr is a string?
There was a problem hiding this comment.
If arr is an object and doesn't have reduce we should throw,
it should likely throw if it is not an array and not an object.
There was a problem hiding this comment.
Cool, thanks for the feedback! Updated per review. :)
Check to see if the `dependentKey` is an array or object, if not, then return the `initialValue`. Closes emberjs#12096
duggiefresh
force-pushed
the
12096-ember-computed-sum
branch
from
7588972
to
2271a93
Compare
rwjblue
added a commit
that referenced
this pull request
Aug 22, 2015
[BUGFIX release] Fix `Ember.computed.sum`
|
Thanks @duggiefresh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to see if the
dependentKeyis an array, if not, then returnthe
initialValue.Closes #12096