[BUGFIX beta] deprecate view and controller keywords #11401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
deprecate-ember-view-keyword
branch
from
f70d4ce
to
9e47c10
Compare
|
Could you also perhaps make a deprecation test for |
mixonic
force-pushed
the
deprecate-ember-view-keyword
branch
from
9e47c10
to
bc7eead
Compare
| } | ||
|
|
||
| function deprecatePath(path) { | ||
| Ember.deprecate(`Using {{${path && path.type === 'PathExpression' && path.parts[0]}}} or any path based on it has been deprecated. Please review the deprecation guide for further details.`, !(path && path.type === 'PathExpression' && (path.parts[0] === 'view' || path.parts[0] === 'controller')), { url: 'http://emberjs.com/deprecations/v1.x#toc_view-and-controller-template-keywords' }); |
There was a problem hiding this comment.
We need the location info in this message (otherwise is it extremely hard to track down and fix). You can use https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/system/calculate-location-display.js to build up the the same string as the other AST transforms.
Take a look at https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-input-on-to-onEvent.js#L50-L59 for an example of how you would interpolate it.
mixonic
force-pushed
the
deprecate-ember-view-keyword
branch
from
bc7eead
to
6bbd3b7
Compare
|
w/ Robert's feedback addressed. |
|
👍 - Fire when Travis is happy. |
mixonic
force-pushed
the
deprecate-ember-view-keyword
branch
3 times, most recently
from
7d7d078
to
0e7367c
Compare
mixonic
force-pushed
the
deprecate-ember-view-keyword
branch
from
0e7367c
to
917e465
Compare
mixonic
added a commit
that referenced
this pull request
Jun 11, 2015
[BUGFIX beta] deprecate view and controller keywords
bantic
added a commit
to bantic/ember.js
that referenced
this pull request
Jun 12, 2015
…lect"}}
Use a template-compiler plugin to detect `{{view "string"}}` at compile-time
and issue a deprecation with location information. Has a special case
deprecation when the string === "select".
Removes a test from the view helper tests that was checking for the
deprecation at runtime (and removes the associated code in
the ember-htmlbars package's `keywords/view`).
Note: This does not catch a deprecation when the path is not a string,
e.g., `{{view view.someProperty}}`, however emberjs#11401 would catch and issue
a deprecation message for that case (at runtime).
Also a few changes to deprecations:
* document `id` param to `Ember.deprecate`
* include deprecation id in log/error message
* Use dot-namespaced deprecation ids (more similar to how `instrument` works and paves the way to in the future changing deprecation log levels by paths ie `"view.*"`)
* globally silence view-related deprecations in tests to avoid overflowing travis ci's log
* update ember-dev dep in bower (pr: emberjs/ember-dev#153) to `a064f0cd2f4c225ffd023b63d4cb31a79db04aaf`
* change the view-and-controller-path template compiler plugin to always deprecate `{{controller}}`
* change the view-and-controller-path template compiler plugin to skip deprecating `{{view}}` when `Ember.ENV._ENABLE_LEGACY_VIW_SUPPORT` is true
refs emberjs#11377
rwjblue
pushed a commit
that referenced
this pull request
Jun 13, 2015
…lect"}}
Use a template-compiler plugin to detect `{{view "string"}}` at compile-time
and issue a deprecation with location information. Has a special case
deprecation when the string === "select".
Removes a test from the view helper tests that was checking for the
deprecation at runtime (and removes the associated code in
the ember-htmlbars package's `keywords/view`).
Note: This does not catch a deprecation when the path is not a string,
e.g., `{{view view.someProperty}}`, however #11401 would catch and issue
a deprecation message for that case (at runtime).
Also a few changes to deprecations:
* document `id` param to `Ember.deprecate`
* include deprecation id in log/error message
* Use dot-namespaced deprecation ids (more similar to how `instrument` works and paves the way to in the future changing deprecation log levels by paths ie `"view.*"`)
* globally silence view-related deprecations in tests to avoid overflowing travis ci's log
* update ember-dev dep in bower (pr: emberjs/ember-dev#153) to `a064f0cd2f4c225ffd023b63d4cb31a79db04aaf`
* change the view-and-controller-path template compiler plugin to always deprecate `{{controller}}`
* change the view-and-controller-path template compiler plugin to skip deprecating `{{view}}` when `Ember.ENV._ENABLE_LEGACY_VIW_SUPPORT` is true
refs #11377
(cherry picked from commit c2bcc86)
This was referenced Aug 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
{{view}}and{{controller}}is deprecated.TODO: