[FEATURE ember-htmlbars-component-generation] Disabled by default. #11267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of issues have been discovered for this feature that make it clear that further consideration is needed before enabling by default. * Cannot use angle-bracket invocation in contexts that require specific tags. For example: you cannot use `<table><custom-row model=stuff></custom-row></table>` because in a `<table>` context like this, you can only use `<tr>` * Cannot use angle-bracket invocation to use components in a subdirectory. * Other things....
rwjblue
added a commit
that referenced
this pull request
May 25, 2015
…on-feature [FEATURE ember-htmlbars-component-generation] Disabled by default.
|
The RFC that led to this disabling is now posted. Since angle bracket components are our one near-term shot to make useful semantic changes, it seems worth waiting an extra release if we can successfully unify a bunch of concepts that are the source of many papercuts today. (on top of the issues @rwjblue raised) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of issues have been discovered for this feature that make it clear that further consideration is needed before enabling by default.
<table><custom-row model=stuff /></table>because in a<table>context like this, you can only use<tr><some-thing />as blockless and<some-thing></some-thing>as having a block. Both scenarios are considered block invocation today.A more thorough review of what this means for future timing will be coming in a blog post by @wycats shortly...