[BUGFIX beta] Change style deprecation to warning. #10711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,12 @@ export default function AttrNode(attrName, attrValue) { | |||
| this.init(attrName, attrValue); | |||
| } | |||
|
|
|||
| export var styleWarning = 'Dynamic content in the `style` attribute is not escaped and may expose your application ' + | |||
There was a problem hiding this comment.
this seems pretty verbose, I fear heavy signal-to-noise. I would be a fan of a single brief sentence and a link for more info.
unsafe use of style attribute bindings, please refer to: ....
rwjblue
force-pushed
the
update-style-warning
branch
4 times, most recently
from
6fd02d4
to
61b8acc
Compare
|
pinged @tomdale for his worth-smithing in slack. |
|
Let's change this to:
|
|
still pretty long, but ultimately fine. Remember people may see a good number of these fly past |
rwjblue
force-pushed
the
update-style-warning
branch
from
61b8acc
to
ea18ee7
Compare
|
Updated |
rwjblue
force-pushed
the
update-style-warning
branch
from
ea18ee7
to
31e61f1
Compare
|
👍 |
rwjblue
added a commit
that referenced
this pull request
Mar 26, 2015
[BUGFIX beta] Change style deprecation to warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @tomdale @ebryn @mixonic @stefanpenner