Deprecate direct use of CoreView #10585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,4 +154,12 @@ CoreView.reopenClass({ | |||
| isViewClass: true | |||
| }); | |||
|
|
|||
| export var DeprecatedCoreView = CoreView.extend({ | |||
| init: function() { | |||
| console.log('init'); | |||
|
+1 other then test failure + what @rwjblue mentioned |
wagenet
force-pushed
the
deprecate-core-view
branch
from
d19d24f
to
c674754
Compare
|
Fixed the console.log. |
rwjblue
added a commit
that referenced
this pull request
Mar 8, 2015
Deprecate direct use of CoreView
|
@rwjblue Should this have a deprecation link? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure this is worth it since we do plan to deprecate View altogether.