Remove meta.descs

[ebryn]

@stefanpenner @krisselden @mmun One less allocation in meta. This also means we dont need to instantiate a meta object just to add a computed property to a POJO.

[ebryn]

I would like a bikeshedding around the fastest/safest way to check if it's a descriptor @stefanpenner @krisselden

[stefanpenner]

although verbose this is likely the best mechanism to check.

Alternatively, as meta.descs is internal, and we vow never to set it to null rather undefined or a value, we wouldn't need the null check. That being said, the null check is essentially free.

[stefanpenner]

ya, we should fix this, should be easy

[stefanpenner]

I suspect having the descriptor be the property will also be less "magical" But lets see how people react.

We should confirm that ember-data behaves correctly with this patch, as it and reduce computed often reach around some of the private meta API

[herom]

Now, that meta.descs is removed (and I also can't find __ember_meta__.descs on Objects anymore), what's the safest way to find out which of the properties of an Object are instances of ComputedProperty?

Until 1.10.0 my following code was working (although I expected it to be pretty "unstable" as it relied on __ember_meta__ (as you can see here):

_stripComputedPropertiesFromModel: function (model) {
    var serializedProperties = get(model, 'serializableProperties');
    var descs = model.__ember_meta__.descs;

    return serializedProperties.filter(function (property) {
      return !(descs[property] instanceof ComputedProperty);
    });
  }

[jmurphyau]

Try this..

_stripComputedPropertiesFromModel: function (model) {
  var serializedProperties = get(model, 'serializableProperties');

  return serializedProperties.filter(function (property) {
    return !(model[property] instanceof ComputedProperty);
  });
}

When you access the properties directly on the object - without using .get() - it returns the computed property

[herom]

thanks @jmurphyau - I tried it in a JSBin example, but it doesn't seem to work?

[jmurphyau]

@herom that JSBin still has meta.descs - it was using Ember 1.10.. Also the check wasn't complete.. I've added a bit more detail - an Ember.computed.alias isn't an instance of an Ember.ComputedProperty.

Take a look at this JSBin using Ember 1.11

[herom]

thanks a lot @jmurphyau - that's great! 👍