[BUGFIX beta] IE10-8 fixes. normalizeProperty expects lowercase prop name #10318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
changed the title
|
I've labelled this bugfix beta, though I'm unsure how smoothly it will merge onto beta. |
| @@ -54,6 +54,8 @@ export default Component.extend(TextSupport, { | |||
| 'width' | |||
| ], | |||
|
|
|||
| defaultLayout: null, | |||
There was a problem hiding this comment.
Need some feedback here. text fields are input tags. In IE8 an exception is raised if you try to append blank text nodes to an input.
text_field is now a component, so a layout makes sense. Not sure why it is being appended to the view element though.
There was a problem hiding this comment.
This does make sense. <input> cannot have child elements, this is just enforcing that (and preventing errors in IE8).
There was a problem hiding this comment.
Fwiw @rwjblue and I have discussed ignoring defaultLayout when there is no template or layout on a component.
mixonic
changed the title
rwjblue
added a commit
that referenced
this pull request
Jan 31, 2015
[BUGFIX beta] IE10-8 fixes. normalizeProperty expects lowercase prop name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly extracted from #10186. IE9+ is all good, IE8 getting closer.