Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parentView undefined during willDestroyElement #12080

Closed
dylanmensaert opened this issue Aug 13, 2015 · 4 comments · Fixed by #13775
Closed

parentView undefined during willDestroyElement #12080

dylanmensaert opened this issue Aug 13, 2015 · 4 comments · Fixed by #13775

Comments

@dylanmensaert
Copy link

This happens at least since v1.13.5. When changing to an older v1.11.1, assert never fails.

jsbin: http://emberjs.jsbin.com/lireho/edit?html,js,output

It would make sense that the parentView is still present since the event is called before the element gets destroyed.
So does this work as intended?

@elbeezi
Copy link

elbeezi commented Aug 15, 2015

seems related to #12105 and #12042

@rwjblue
Copy link
Member

rwjblue commented Apr 18, 2016

Confirmed that this is still an issue with current canary (what will be 2.7): http://rwjblue.jsbin.com/dupafa/edit?html,js,output.

@jelhan
Copy link
Contributor

jelhan commented Jun 1, 2016

Investigated a little bit when this bug occurs since I had to write a test if a work-a-round handles the bug correctly. Had confusing results: https://ember-twiddle.com/9319ab95eb9e1d33c7bdae19d57ccd66?openFiles=templates.application.hbs%2Ctemplates.components.parent-component.hbs

@rwjblue
Copy link
Member

rwjblue commented Jul 1, 2016

Added assertions to tests being added in #13775 to ensure that this does not regress again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants