Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

willDestroyElement is not always called #12042

Closed
ilkkao opened this issue Aug 10, 2015 · 4 comments
Closed

willDestroyElement is not always called #12042

ilkkao opened this issue Aug 10, 2015 · 4 comments

Comments

@ilkkao
Copy link
Contributor

ilkkao commented Aug 10, 2015

Seeing this problem in my app:

http://emberjs.jsbin.com/cijamo/edit?html,js,console,output

Matching willDestroyElement call is missing.

@ilkkao
Copy link
Contributor Author

ilkkao commented Aug 10, 2015

Multiple button clicks in the example seem to cause also a memory leak.

@EricSchank
Copy link
Contributor

Looks like this works as expected in 1.12.1, but doesn't dispatch the willDestroyElement hook in 1.13.1

@elbeezi
Copy link

elbeezi commented Aug 15, 2015

seems related to #12105 and #12080

@GavinJoyce
Copy link
Member

I just tried the jsbin on 2.3 and it seems to be working now (I also verified that it is broken in 1.13.1)

@ilkkao perhaps you could confirm that this is no longer an issue for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants