Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFieldComponent Resolver Issue #11326

Closed
RobbieTheWagner opened this issue Jun 2, 2015 · 12 comments
Closed

TextFieldComponent Resolver Issue #11326

RobbieTheWagner opened this issue Jun 2, 2015 · 12 comments
Labels
Milestone

Comments

@RobbieTheWagner
Copy link
Member

We use the default globals resolver in our app, and we have an issue when trying to use the {{input}} helper in our app. We just upgraded to 1.13, and apparently, the default component name is now -text-field, which resolves to the TextFieldComponent that we defined ourselves in our app. I spoke with @rwjblue about this on slack, and we agreed it is a bug that should be looked at.

var defaultComponentName = "-text-field";

@rwjblue
Copy link
Member

rwjblue commented Jun 2, 2015

Thanks for reporting. I'll try to look into it tonight....

@rwjblue rwjblue added the Bug label Jun 2, 2015
@rwjblue rwjblue added this to the 1.13.0 milestone Jun 2, 2015
@rwjblue
Copy link
Member

rwjblue commented Jun 3, 2015

The global resolver will resolve component:-text-field to App.TextFieldComponent, which in this case is conflicting with another component that you have.

Demo JSBin: http://emberjs.jsbin.com/rwjblue/573/edit

@RobbieTheWagner
Copy link
Member Author

Right, but how do we remedy this? Could we perhaps make the default component name something more specific, to reduce the likelihood that other people run into this?

@rwjblue
Copy link
Member

rwjblue commented Jun 3, 2015

The globals resolver should be looking for App._TextFieldComponent which would not conflict, I was explaining what was happening above (not saying y'all were doing something wrong). Definitely a bug we need to fix.

@RobbieTheWagner
Copy link
Member Author

👍

@RobbieTheWagner
Copy link
Member Author

Any luck with this? I'd like to try to update to 1.13.0, but I still can't because none of our {{input}} work.

@RobbieTheWagner
Copy link
Member Author

If this isn't going to be fixed, please let me know, so we can move on and change our code to work with the broken resolver.

@RobbieTheWagner
Copy link
Member Author

Been a couple months now. Any progress on this? If it's an issue that will not be fixed, I would very much like to know, so we can proceed accordingly. This is one of the major hurdles we have updating to Ember 2.0.

@mixonic
Copy link
Sponsor Member

mixonic commented Jul 26, 2015

@rwwagner90 it doesn't look like anyone has had the time to prioritize this yet.

@RobbieTheWagner
Copy link
Member Author

@mixonic yeah, I understand there are higher priorities for you guys, but if the intention is never to fix this, that's fine too, I'm just stuck in limbo not knowing now. I'd like a definite, "we will eventually fix this" or a definite "you're the only one this effects and we're never going to fix this, just rework your naming of components so this conflict does not occur". Could someone answer that please?

@rwjblue
Copy link
Member

rwjblue commented Jul 27, 2015

Quoting from #11326 (comment):

Definitely a bug we need to fix.

skeate added a commit to skeate/ember.js that referenced this issue Sep 29, 2015
Resolves emberjs#11326. If a piece of a name starts with dash (-), it will be
changed into an underscore (_).
@RobbieTheWagner
Copy link
Member Author

Woo @skeate ! 😄

rwjblue pushed a commit that referenced this issue Oct 3, 2015
Resolves #11326. If a piece of a name starts with dash (-), it will be
changed into an underscore (_).

(cherry picked from commit 85d725c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants