Add jQuery shim as part of RFC386 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes ´import jQuery from 'jquery';` work, without transpiling it to `Ember.$`.
16 tasks
rwjblue
reviewed
Jan 20, 2019
There was a problem hiding this comment.
I think it will still require some changes to ember-cli-babel (like emberjs/ember-cli-babel#176 and emberjs/ember-cli-babel#260)
|
@rwjblue yes, indeed. I have this on the quest issue's list, but not tackled yet! I will ping you when that is prepared, would love a round of reviews then, which maybe is a bit easier when all the PRs are prepared, as they are mostly connected somehow. |
|
Sounds great, just ping me (probably in discord?) with the list when you have things queued up.... |
rwjblue
approved these changes
Jan 22, 2019
|
To become part of v0.6.0. |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
import jQuery from 'jquery';work, without transpiling it toEmber.$.