Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement managed array for schemaRecord #9240

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Conversation

richgt
Copy link
Contributor

@richgt richgt commented Feb 29, 2024

Adds support for simple autotracked arrays to schema-record.

basic schema:

{
  name: 'favoriteNumbers',
  type: null,
  kind: 'array',
},

per-item transformation is supported:

 {
  name: 'favoriteNumbers',
  type: 'string-from-int',
  kind: 'array',
}

The fields will appear and act as native arrays.

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature labels Mar 18, 2024
@runspired runspired changed the title implement managed array for schemaRecord feat: implement managed array for schemaRecord Mar 18, 2024
@runspired runspired marked this pull request as ready for review March 18, 2024 23:41
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In follow up we should add tests around recoverability/behavior if the transform errors on item insertion / an out-of-bounds index set or length set occurs.

@runspired runspired merged commit 40fa283 into main Mar 18, 2024
31 of 33 checks passed
@runspired runspired deleted the richgt/schema-array branch March 18, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants