Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: burn down runloop and RSVP usage #8860

Merged
merged 6 commits into from
Sep 11, 2023
Merged

chore: burn down runloop and RSVP usage #8860

merged 6 commits into from
Sep 11, 2023

Conversation

runspired
Copy link
Contributor

Work towards killing off runloop dependencies

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies ci-perf Activates Performance Checks in CI 🔌 Project Unplug 🔌 labels Sep 11, 2023
@github-actions
Copy link

Performance Report for 60f3b9f

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-23ms to 54ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-3ms to 0ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-4ms to 3ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-14ms to 12ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-12ms to 31ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-2ms to 9ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-12ms to 5ms]
✅ Phase [navigationStart] => [start-find-all]
phase estimated improvement -2ms [-4ms to 0ms] OR -1.55% [-3.17% to -0.18%]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-4ms to 5ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-8ms to 3ms]
⚠️ Phase [end-materialization] => [Test End]
phase estimated regression +1ms [0ms to 4ms] OR +4.22% [0.89% to 10.13%]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-79ms to 41ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-2ms to 2ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-2ms to 1ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-17ms to 3ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-7ms to 4ms]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-43ms to 65ms]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-14ms to 4ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-11ms to 2ms]
✅ Phase [navigationStart] => [start-push-payload]
phase estimated improvement -2ms [-5ms to 0ms] OR -0.96% [-1.83% to -0.1%]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-5ms to 5ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-3ms to 1ms]
⚠️ Phase [end-unload-records] => [Test End]
phase estimated regression +1ms [0ms to 1ms] OR +1.61% [1.03% to 2.17%]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-26ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 1ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-17ms to 6ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-5ms to 5ms]
✅ Phase [start-unload-all] => [end-unload-all]
phase estimated improvement -21ms [-26ms to -15ms] OR -3.87% [-4.82% to -2.88%]
⚠️ Phase [end-unload-all] => [Test End]
phase estimated regression +17ms [16ms to 18ms] OR +47.9% [43.96% to 51.03%]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -11ms [-19ms to -4ms] OR -1.1% [-1.9% to -0.37%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 2ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-4ms to 8ms]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -11ms [-15ms to -7ms] OR -7.26% [-9.73% to -4.84%]
✅ Phase [end-destroy-records] => [Test End]
phase estimated improvement -1ms [-2ms to 0ms] OR -2.47% [-4.66% to -1.07%]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-13ms to 1ms]
✅ Phase [navigationStart] => [start-push-initial-payload]
phase estimated improvement -5ms [-9ms to -2ms] OR -1.86% [-3.14% to -0.75%]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-5ms to 3ms]
⚠️ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated regression +4ms [0ms to 7ms] OR +1.72% [0.03% to 3.48%]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +9ms [2ms to 16ms] OR +1.04% [0.24% to 1.87%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [0ms to 5ms]
⚠️ Phase [start-push-payload] => [end-push-payload]
phase estimated regression +7ms [2ms to 13ms] OR +1.34% [0.37% to 2.31%]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-1ms to 0ms]

@runspired runspired merged commit ac092d1 into main Sep 11, 2023
19 of 21 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cleanup-event-loop branch September 11, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-perf Activates Performance Checks in CI 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies 🔌 Project Unplug 🔌
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

1 participant