Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite addMixin #8850

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Overwrite addMixin #8850

merged 2 commits into from
Sep 10, 2023

Conversation

patricklx
Copy link
Contributor

@patricklx patricklx commented Sep 6, 2023 •
edited
Loading

fixes #8847

@patricklx patricklx marked this pull request as draft September 6, 2023 21:16
@patricklx patricklx marked this pull request as ready for review September 7, 2023 05:05
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue 🎯 canary PR is targeting canary (default) labels Sep 10, 2023
@runspired runspired merged commit 5a771b3 into emberjs:main Sep 10, 2023
38 of 42 checks passed
kategengler pushed a commit that referenced this pull request Feb 8, 2024
@patricklx @kategengler
Overwrite addMixin (#8850)
3b9fc10 
* use addMixin

* here too

(cherry picked from commit 5a771b3)
@kategengler kategengler mentioned this pull request Feb 8, 2024
Open
Baltazore pushed a commit that referenced this pull request May 10, 2024
@patricklx @Baltazore
Overwrite addMixin (#8850)
ff8d69a 
* use addMixin

* here too

(cherry picked from commit 5a771b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion Failed: Do not use A() on an EmberData PromiseManyArray
2 participants
@patricklx @runspired