Avoid linting .html files by default
#1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MelSumner
approved these changes
Feb 9, 2021
rwjblue
approved these changes
Feb 9, 2021
rwjblue
changed the title
.html files by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing the new beta for v3 we discovered some issues with HTML parsing. Specifically, this issue related to doctype, and part of the original fix was done in #1720.
During that PR, it was decided to attempt to fix the issue at source, which requires tildeio/simple-html-tokenizer#71 and some additional changes in @glimmery/syntax.
While those fixes above are in progress, we discussed disabling the HTML parsing. If the above PRs get shipped and merged in time for v3, we can re-enable this. If not, we'll roll it out in a follow up post-v3.